Only allocate tempStorage once #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While loading seeds into memory for the GPU to use, realloc() was called multiple times resulting in a lot of copying.
riking
commented
Apr 15, 2020
| arraySize=0; | ||
| arraySize = 0; | ||
| for(int gpu_index = 0; gpu_index < GPU_COUNT; gpu_index++) { | ||
| arraySize += *nodes[gpu_index].num_seeds; |
There was a problem hiding this comment.
broken, this needs the Synchronize moved above it
|
merged into #4 |
|
uh wtf, the seeds returned by the gpu aren't constant at all accross runs |
|
we can for sure have a upper bound for the array but that array would be way too large |
|
The number to allocate for each run is calculated after the GPUs are done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While loading seeds into memory for the GPU to use, realloc() was called multiple times resulting in a lot of copying.