-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up tox-conda/pytest #1
Commits on Nov 7, 2024
-
- Set build-backend so isolated pip install works - Add pychop as testing dependency - Configure tox-conda - Create __init__.py files under tests/ so that all tests are found by pytest We need to use conda to install Mantid and check results against Abins functions. Tox-conda is stuck on tox v3; there is a branch to support v4 but it's not clear if/when this will be finished. But we also might be able to drop the conda component of these tests once we are satisfied with validation against Mantid: it can be replaced with tests against reference values. Perhaps we don't need the test dependencies at all in pyproject.toml, now this is all defined in tox.ini. But they could be useful for running tests without tox if desired.
Configuration menu - View commit details
-
Copy full SHA for 88391f9 - Browse repository at this point
Copy the full SHA 88391f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0785ae - Browse repository at this point
Copy the full SHA f0785aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a3c3c - Browse repository at this point
Copy the full SHA e5a3c3cView commit details
Commits on Nov 8, 2024
-
- Use reservoir sampling to efficiently grab a subset of Fermi chopper frequency combinations - Simplify error matching with match= argument - Get id on the fly with a function rather than precomputing
Configuration menu - View commit details
-
Copy full SHA for eb7f15c - Browse repository at this point
Copy the full SHA eb7f15cView commit details -
- defer string ids to a function run by test - replace explicit list-extending with itertools.chain
Configuration menu - View commit details
-
Copy full SHA for bd5d48e - Browse repository at this point
Copy the full SHA bd5d48eView commit details -
More unit_tests cleanup: type annotations, stricter error check
The sweep of incident energies is cut down by some more (seeded) random sampling. At the moment we have some cases with invalid chopper frequencies; make sure the error is checked robustly when handling these. Ideally we should have smarter test-case generation and check the errors in a separate test
Configuration menu - View commit details
-
Copy full SHA for 64e8b75 - Browse repository at this point
Copy the full SHA 64e8b75View commit details -
Update pyproject.toml with another test dependency.
These aren't currently being checked in CI because tox takes care of it, so can easily become stale. There must be a better way.
Configuration menu - View commit details
-
Copy full SHA for 9210cdc - Browse repository at this point
Copy the full SHA 9210cdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8928d96 - Browse repository at this point
Copy the full SHA 8928d96View commit details
Commits on Nov 11, 2024
-
Try running on windows as well
We are seeing some interesting inconsistencies in test results between Rastislav's local Windows installation and my Linux/tox setup.
Configuration menu - View commit details
-
Copy full SHA for 2872756 - Browse repository at this point
Copy the full SHA 2872756View commit details -
We know some tests are failing regardless, but want to see what happens on Windows!
Configuration menu - View commit details
-
Copy full SHA for b5e2676 - Browse repository at this point
Copy the full SHA b5e2676View commit details -
Tweak Abins-Pychop test; LinAlgError is only encountered on Windows
When testing on Linux, Abins returns NaN rather than raise LinAlgError when the chopper settings are out of range. Our test should detect both cases and ensure appropriate behaviour in corresponding situation. (i.e. raise NoTransmissionError)
Configuration menu - View commit details
-
Copy full SHA for 4fc9ab8 - Browse repository at this point
Copy the full SHA 4fc9ab8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c7023e - Browse repository at this point
Copy the full SHA 4c7023eView commit details -
Detect PyChop Warning in Abins integration test
This is a bit cleaner than having separate checks for different OS/Library situations
Configuration menu - View commit details
-
Copy full SHA for 8efd6dc - Browse repository at this point
Copy the full SHA 8efd6dcView commit details -
Skip Lagrange low-frequency comparison with Abins
There is a unit-conversion bug in the low-frequency limit so this doesn't kick in at the right place in Abins. When that is fixed we can de-skip the test and verify it here.
Configuration menu - View commit details
-
Copy full SHA for 1a45e22 - Browse repository at this point
Copy the full SHA 1a45e22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26a3d33 - Browse repository at this point
Copy the full SHA 26a3d33View commit details