v3.2.7

.github/workflows/runtests.yml

@@ -21,6 +21,8 @@ jobs:
           poetry-version: ${{ matrix.poetry-version }}
       - name: Setup dependencies
         run: poetry install
+      - name: Run linter
+        run: poetry run flake8
       - name: Run tests
         run: poetry run pytest --cov=spook && poetry run coverage xml
       - name: Upload to codecov

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "spook"
-version = "3.2.6"
+version = "3.2.7"
 description = "Django Rest Framework library to interconnect external APIs"
 authors = ["Pablo Moreno <[email protected]>"]
 license = "MIT"
@@ -20,7 +20,7 @@ classifiers = [
 
 [tool.poetry.dependencies]
 python = ">=3.7,<4"
-django = ">= 1.11.0"
+django = ">= 2.2.0"
 djangorestframework = ">= 3.3.1"
 requests = ">= 2.24.0"
 coverage = ">= 5.3"
@@ -31,6 +31,7 @@ wheel = "^0.34.2"
 pytest = "^6.0.1"
 coverage = "^5.3"
 pytest-cov = "^2.12.0"
+flake8 = "^3.9.2"
 
 [build-system]
 requires = ["poetry>=0.12"]

spook/resources.py

@@ -1,4 +1,3 @@
-import enum
 from json import JSONDecodeError
 
 import requests
@@ -79,7 +78,7 @@ def get_headers(self) -> dict:
     def get_response_data(self, response) -> Union[dict, str]:
         try:
             response_data = response.json()
-        except (JSONDecodeError, Exception) as e:
+        except (JSONDecodeError, Exception):
             response_data = response.content
 
         return response_data
@@ -176,7 +175,7 @@ def post(self, data: dict, query: dict = None) -> APIResourceResponse:
         validated_data = self.validate(data, action="create")
         response = self.http.post(
             self.get_url(),
-            data=validated_data,
+            json=validated_data,
             headers=self.get_headers(),
             params=query,
         )

spook/tests/test_spook.py

@@ -4,8 +4,22 @@
 from rest_framework.exceptions import ValidationError
 from rest_framework.test import APITestCase
 
+from spook.resources import APIResource
+from spook.tests.mocks import (
+    ProductResource,
+    get_mocked_products,
+    PRODUCTS,
+    retrieve_product,
+    create_product,
+    CREATED_PRODUCT,
+    update_product,
+    UPDATED_PRODUCT,
+    delete_product,
+    server_error,
+    server_validation_error,
+    server_permission_error,
+)
 from spook.utils import get_model_slug
-from spook.tests.mocks import *
 
 
 class TestAPIResource(APITestCase):

spook/tests/test_views.py

@@ -3,9 +3,20 @@
 from unittest.mock import patch
 from rest_framework.test import APITestCase
 
-from spook.views import *
-from spook.tests.mocks import *
+from spook.tests.mocks import (
+    ProductSerializer,
+    ProductResource,
+    get_mocked_products,
+    PRODUCTS,
+    retrieve_product,
+    create_product,
+    CREATED_PRODUCT,
+    update_product,
+    UPDATED_PRODUCT,
+    delete_product,
+)
 from spook.tests.utils import MockedRequest
+from spook.views import APIResourceListCreateView, APIResourceRetrieveUpdateDestroyView
 
 
 class NoResourceView(APIResourceListCreateView):

spook/tests/utils.py

@@ -1,9 +1,5 @@
 from json import JSONDecodeError
 
-from django.db import connection
-from django.db.models.base import ModelBase
-from rest_framework.test import APITestCase
-
 
 class MockedResponse(object):
     def __init__(self, data, status_code=200):

spook/views.py

@@ -40,7 +40,6 @@ def list(self, request, *args, **kwargs):
         resource = self.get_resource()
         token = self.get_token(request)
         params = request.query_params
-        serializer = self.get_serializer_class()
         context = {
             "request": request,
         }

tox.ini

@@ -0,0 +1,2 @@
+[flake8]
+ignore = E501,F401,F403