add setting for disable the token configuratiob check

p4535992 · Feb 15, 2023 · 7acfe97 · 7acfe97
1 parent 02fc493
commit 7acfe97
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 6 deletions.
diff --git a/src/languages/en.json b/src/languages/en.json
@@ -77,6 +77,10 @@
 				"name": "Enable 'can move constrained'",
 				"hint": "Enable the new 'Can Move Constrained' feature from Token Attacher"
 			},
+            "disableTokenConfigurationCheck": {
+                "name": "Disable token configuration check",
+				"hint": "I don't quite understand why, but some people have problems getting the flags on the token configuration to work .... after hundreds of tests from my high successfully I give up to understand why , enabling this module settings ignores the setting control on the token configuration and uses those at the module level (as it was for the pre 3.4.X version)."
+            },
 			"enableDragAndDropMountUp": {
 				"name": "Enable drag and drop token for mountup",
 				"hint": "If Enabled when dragging and dropped a token it will try to mount the below token if present and if you have owner permissions on that token"

diff --git a/src/scripts/api.ts b/src/scripts/api.ts
@@ -26,8 +26,12 @@ const API = {
 		}
 
 		if (!(String(mountToken.actor?.getFlag(CONSTANTS.MODULE_NAME, MountUpFlags.IsAMount)) === "true")) {
-			warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
-			return;
+            if(game.settings.get(CONSTANTS.MODULE_NAME,"disableTokenConfigurationCheck")) {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }));
+            } else {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
+                return;
+            }
 		}
 
 		const mountName = mountToken.name;

diff --git a/src/scripts/mountManager.ts b/src/scripts/mountManager.ts
@@ -20,8 +20,12 @@ export class MountManager {
 			return;
 		}
 		if (!(String(mountToken.actor?.getFlag(CONSTANTS.MODULE_NAME, MountUpFlags.IsAMount)) === "true")) {
-			warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
-			return;
+            if(game.settings.get(CONSTANTS.MODULE_NAME,"disableTokenConfigurationCheck")) {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }));
+            } else {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
+                return;
+            }
 		}
 		const tokensToCheck = canvas.tokens?.controlled || [];
 		for (const riderToken of tokensToCheck) {
@@ -127,8 +131,12 @@ export class MountManager {
 			return false;
 		}
 		if (!(String(mountToken.actor?.getFlag(CONSTANTS.MODULE_NAME, MountUpFlags.IsAMount)) === "true")) {
-			warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
-			return false;
+            if(game.settings.get(CONSTANTS.MODULE_NAME,"disableTokenConfigurationCheck")) {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }));
+            } else {
+                warn(i18nFormat(`${CONSTANTS.MODULE_NAME}.isNotAMount`, { mount: mountToken.name }), true);
+                return false;
+            }
 		}
 		let riders = <string[]>mountToken.actor?.getFlag(CONSTANTS.MODULE_NAME, MountUpFlags.Riders);
 		if (riders === undefined) riders = [];

diff --git a/src/scripts/settings.ts b/src/scripts/settings.ts
@@ -199,6 +199,15 @@ export const registerSettings = function () {
 		default: "{rider} has dismounted from {mount}.",
 	});
 
+	game.settings.register(CONSTANTS.MODULE_NAME, "disableTokenConfigurationCheck", {
+		name: `${CONSTANTS.MODULE_NAME}.setting.disableTokenConfigurationCheck.name`,
+		hint: `${CONSTANTS.MODULE_NAME}.setting.disableTokenConfigurationCheck.hint`,
+		scope: "client",
+		config: true,
+		default: false,
+		type: Boolean,
+	});
+
 	game.settings.register(CONSTANTS.MODULE_NAME, "enableDragAndDropMountUp", {
 		name: `${CONSTANTS.MODULE_NAME}.setting.enableDragAndDropMountUp.name`,
 		hint: `${CONSTANTS.MODULE_NAME}.setting.enableDragAndDropMountUp.hint`,