fix: autosubmit UB

p2sr · Nov 26, 2024 · 818ea9a · 818ea9a
1 parent 8b50a00
commit 818ea9a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/src/Features/AutoSubmit.cpp b/src/Features/AutoSubmit.cpp
@@ -139,7 +139,7 @@ static void testApiKey() {
 	// FIXME: add API maps endpoint on board.portal2.sr
 	if (sar.game->Is(SourceGame_Portal2)) {
 		for (const auto &map : Game::maps) {
-			if (map.chamberId != "") {
+			if (strlen(map.chamberId) > 0) {
 				g_map_ids.insert({map.fileName, map.chamberId});
 			}
 		}

diff --git a/src/Features/PlayerTrace.cpp b/src/Features/PlayerTrace.cpp
@@ -1091,7 +1091,6 @@ CON_COMMAND(sar_trace_compare, "sar_trace_compare <trace 1> <trace 2> - compares
 
 	console->Print("Comparing traces \"%s\" and \"%s\":\n", trace1Name, trace2Name);
 
-	const auto goodColor = Color(110, 247, 76);
 	const auto badColor = Color(255, 100, 100);
 
 	auto startTick1 = tickInternalToUser(0, *trace1);