Use node 20 to build frontend

p2pu · Apr 4, 2024 · 2d021de · 2d021de
1 parent 298f3d1
commit 2d021de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/website-deploy.yml b/.github/workflows/website-deploy.yml
@@ -50,7 +50,7 @@ jobs:
         run: cat ./_data/teams.json | python3 _deploy/team_pages.py
 
       - name: build frontend
-        run: docker run --rm --volume `pwd`:/opt/app --workdir /opt/app node:14 /bin/sh -c "npm install && npm run build"
+        run: docker run --rm --volume `pwd`:/opt/app --workdir /opt/app node:20 /bin/sh -c "npm install && npm run build"
 
       - name: build jekyll site
         run: docker run -v `pwd`:/opt/app -v `pwd`/_site:/opt/app/_site local/p2pu-website jekyll build --future --config _config.yml,_production.yml
@@ -59,7 +59,7 @@ jobs:
         run: docker network create test-net
 
       - name: test setup
-        run: docker run --name site --workdir /tmp -d --network test-net --publish 3000:3000 --volume `pwd`/_site:/var/www node:14 /bin/sh -c "npm i serve && npx serve -l 3000 /var/www"
+        run: docker run --name site --workdir /tmp -d --network test-net --publish 3000:3000 --volume `pwd`/_site:/var/www node:20 /bin/sh -c "npm i serve && npx serve -l 3000 /var/www"
 
       - name: build docker image for testing with puppeteer
         run: docker build ./docker/puppeteer/ -t local/puppeteer

diff --git a/.github/workflows/website-staging.yml b/.github/workflows/website-staging.yml
@@ -103,13 +103,13 @@ jobs:
         run: cat ./_data/teams.json | python3 _deploy/team_pages.py
 
       - name: build frontend
-        run: docker run --rm --volume `pwd`:/opt/app --workdir /opt/app node:14 /bin/sh -c "npm install && npm run build"
+        run: docker run --rm --volume `pwd`:/opt/app --workdir /opt/app node:20 /bin/sh -c "npm install && npm run build"
 
       - name: build jekyll site
         run: docker run -v `pwd`:/opt/app -v `pwd`/_site:/opt/app/_site local/p2pu-website jekyll build --future --config _config.yml,_production.yml
 
       - name: test setup
-        run: docker run --name=site -d --volume `pwd`/_site:/var/www node:14 /bin/sh -c "npm i serve && npx serve -l 3000 /var/www"
+        run: docker run --name=site -d --volume `pwd`/_site:/var/www node:20 /bin/sh -c "npm i serve && npx serve -l 3000 /var/www"
 
       - name: build docker image for testing using puppeteer
         run: docker build ./docker/puppeteer/ -t local/puppeteer

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -14,7 +14,7 @@ services:
     - BUNDLE_PATH=/opt/bundler
     command: bundle exec jekyll serve -H 0.0.0.0 --watch --config _config.yml,_config.dev.yml
   node:
-    image: node:18
+    image: node:20
     user: 1000:1000
     working_dir: /opt/app
     #ports: