Tags count in view #158
Closed
Tags count in view #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -847,6 +836,7 @@ def admin_metrics_data_ajax(request, slug): | |||
| participants = project.participants( | |||
| include_deleted=True).order_by('user__username') | |||
| participant_profiles = (participant.user for participant in participants) | |||
| tracker_models.update_metrics_cache(project) | |||
There was a problem hiding this comment.
this came with the pull, but cannot see it in the latest file.
There was a problem hiding this comment.
this line was removed in a previous commit, don't know how the pull managed to put them back?
|
Hey Dirk, added the changes to this pr; if you can have a look, that would be great. cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Dirk,
could you please have a look at the commits? It adds a test to re-create issue #156 and a potential fix.
I wanted to refactor more in the view but that Sigup class is really getting in the way. Will keep on adding tests anyway, but not related to this bug.
cheers!
PS: will add some comments on the tracker lines that got pulled in this afternoon; not sure how that happen but don't see them in the new file.