Fixing email notifications that did not work correctly #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except OSError: | ||
| # something bad happened, so just return the input | ||
| return value |
There was a problem hiding this comment.
Have a look how text content is generated from HTML emails for the Mechanical MOOC: https://github.com/p2pu/mechanical-mooc/blob/master/mail/views.py#L22-L27.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "your Badge is created and published" email was sent before the badge was published, so I have duplicated the functionality with slight tweaks in the copy.
I also had to add another template filter, since emails that are sent in text form got ugly HTML rendering which is saved in DB.