Use cztop instead of rbzmq #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because rbzmq is unmaintained. cztop is maintained and prepared Windows fat gem.
Because Fluent::Engine.msgpack_factory exists v0.12.17 or later.
|
Bump? |
|
ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because rbzmq has been unmaintained since 4 years.
Let's migrate to use cztop instead of rbzmq.
cztop also provides fat gem for Windows.
Also this PR contains EventTime ext type fixes for v0.14 which can achieve with
Fluent::Engine.msgpack_factory.unpacker's#feedand#readinstances.Could you take a look?
Thanks in advance,