Add subcommand to "hydrate" a task dump #520
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
requested review from
cbiffle,
bcantrill,
jgallagher,
hawkw and
labbott
labbott
reviewed
Nov 18, 2024
| let Subcommand::Other(subargs) = context.cli.cmd.as_ref().unwrap(); | ||
| let subargs = Args::try_parse_from(subargs)?; | ||
| let f = std::fs::File::open(&subargs.file)?; | ||
| let mut z = zip::ZipArchive::new(f)?; |
There was a problem hiding this comment.
How well documented/stable is this format and how mad are we going to be if we need to change it in the future?
There was a problem hiding this comment.
I don't expect it to change much, because there's only so many ways to represent a bunch of bytes. Still, I added meta.json containing a version value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See oxidecomputer/management-gateway-service#316
and oxidecomputer/hubris#1921 for details
This PR adds a new
humility hydratesubcommand, which takes a "dry" task dump and staples it to a Hubris archive, creating a normal Hubris core file.