Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for PSU firmware update #1934

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add support for PSU firmware update #1934

wants to merge 8 commits into from

Conversation

bcantrill
Copy link
Collaborator

No description provided.

mkeeter
mkeeter reviewed Nov 22, 2024
View reviewed changes
drv/i2c-devices/src/mwocp68.rs
}

fn get_boot_loader_mode(&self) -> Result<BOOT_LOADER_STATUS::Mode, Error> {
Ok(self.get_boot_loader_status()?.get_mode().unwrap())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment here explaining that mode is a 1-bit value, so it's always valid?

hawkw
hawkw reviewed Nov 22, 2024
View reviewed changes
Copy link
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me! i had some very minor drive-by suggestions which may or may not be useful.

drv/i2c-devices/src/mwocp68.rs Show resolved Hide resolved
drv/i2c-devices/src/mwocp68.rs Show resolved Hide resolved
drv/i2c-devices/src/mwocp68.rs Outdated Show resolved Hide resolved
drv/i2c-devices/src/mwocp68.rs Outdated Show resolved Hide resolved
drv/psc-psu-update/src/main.rs Show resolved Hide resolved
drv/i2c-devices/src/mwocp68.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkw hawkw hawkw left review comments

@mkeeter mkeeter mkeeter left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcantrill @mkeeter @hawkw