Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimlet-seq-server: use set_bytes not write_bytes for sequencing control #1930

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

Aaron-Hartwig
Copy link
Contributor

Fixes #1929

Since write_bytes uses the Write operation, we effectively clear the A1 bit when setting the A0 bit. Using set_bytes uses a BitSet operation, allowing us to set A0 while leaving A1 in place. The FPGA has papered over this by ignoring the A1 bit while it is in A0.

Copy link
Contributor

@nathanaelhuffman nathanaelhuffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur. Without this, we're actually commanding the A1 state machine back to IDLE, but it holds the A1 rails up because A0 rails are still up and we have sequencing requirements so everything "works" even though this was currently wrong.

@Aaron-Hartwig Aaron-Hartwig enabled auto-merge (squash) November 22, 2024 22:03
@Aaron-Hartwig Aaron-Hartwig merged commit 38c0571 into master Nov 22, 2024
125 checks passed
@Aaron-Hartwig Aaron-Hartwig deleted the aaron/gimlet-seq-fix branch November 22, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gimlet_seq should use set_bytes, not write_bytes when setting individual bits
2 participants