xtask lsp: add HUBRIS_TASK environment variable #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeter
reviewed
Sep 20, 2024
build/xtask/src/lsp.rs
Outdated
| // Try to be specific about the error condition. | ||
| let apps = preferred_apps.join(", "); | ||
| if let Some(taskname) = preferred_task { | ||
| Err(anyhow!("task {taskname} not found or {package_name} is not used; \ |
There was a problem hiding this comment.
Nit: bail!(...) is incrementally shorter than Err(anyhow!(...))
mkeeter
approved these changes
Sep 20, 2024
cbiffle
force-pushed
the
cbiffle/xtask-lsp-task-name
branch
from
96ebb9e
to
1476c97
Compare
Setting HUBRIS_TASK causes xtask lsp to only search tasks of a specific name, across configured apps (either the default set, or the one chosen by HUBRIS_APP). This can be useful to get the cfgs right for a specific case.
cbiffle
force-pushed
the
cbiffle/xtask-lsp-task-name
branch
from
1476c97
to
f3a1881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting HUBRIS_TASK causes xtask lsp to only search tasks of a specific name, across configured apps (either the default set, or the one chosen by HUBRIS_APP).
This can be useful to get the cfgs right for a specific case.