Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sidecar: fix comment about fan rotor ordering #1445

Merged
merged 1 commit into from
Aug 9, 2023
Merged

sidecar: fix comment about fan rotor ordering #1445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/sidecar/base.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ address = 0b0100_011
device = "max31790"
name = "East"
description = "Fan 0/1 controller"
sensors = { speed = 4, names = [ "NE_fan1", "SE_fan1", "ENE_fan0", "ESE_fan0" ] }
sensors = { speed = 4, names = [ "SE_fan1", "NE_fan1", "ESE_fan0", "ENE_fan0" ] }
refdes = "U66"

[[config.i2c.devices]]
Expand Down Expand Up @@ -604,7 +604,7 @@ address = 0b0100_000
device = "max31790"
name = "West"
description = "Fan 2/3 controller"
sensors = { speed = 4, names = [ "WNW_fan3", "WSW_fan3", "NW_fan2", "SW_fan2", ] }
sensors = { speed = 4, names = [ "WSW_fan3", "WNW_fan3", "SW_fan2", "NW_fan2" ] }
refdes = "U78"

[[config.i2c.devices]]
Expand Down
16 changes: 8 additions & 8 deletions task/thermal/src/bsp/sidecar_bc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ impl Bsp {
// controller and fan index:
//
// System Index Controller Fan MAX31790 Fan (Datasheet)
// 0 East ENE 2 (3)
// 1 East ESE 3 (4)
// 2 East NE 0 (1)
// 3 East SE 1 (2)
// 4 West NW 2 (3)
// 5 West SW 3 (4)
// 6 West WNW 0 (1)
// 7 West WSW 1 (2)
// 0 East ESE 2 (3)
// 1 East ENE 3 (4)
// 2 East SE 0 (1)
// 3 East NE 1 (2)
// 4 West SW 2 (3)
// 5 West NW 3 (4)
// 6 West WSW 0 (1)
// 7 West WNW 1 (2)
//

// The supplied `fan` is the System Index. From that we can map to a fan
Expand Down