Improve external ips row #2576
Open
Improve external ips row #2576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Added a little spacing to the left of the badge. Would be open to adding a slash between the last IP and the |
|
|
The badge is more visible, but we're not using it in other cases of overflow. Let's match the treatment elsewhere that just uses the mono. We might need some container to distinguish it from the addresses themselves but let's start there. |
|
I love the idea of linking to the networking tab. What if we used an info icon to link to the networking tab even when there is no overflow? That could let us avoid having to indicate which are floating or ephemeral inline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Ephemeral IP to the end of the list of IPs in the minitable at the top of the screen. It also caps the number of IPs shown, with an overflow badge (
+3or whatever) that directs the user to the Networking page.Showing two IPs, with the Floating IP first:
When there are more than 2 IPs:
Closes #2570