Don't error if nonce is a number string

oxheadalpha · Oct 15, 2023 · 60a6da6 · 60a6da6
1 parent e6d1aa0
commit 60a6da6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/middleware.ts b/src/middleware.ts
@@ -79,14 +79,15 @@ const validateChallengeBody = (
 ) => {
   if (!env.DISABLE_CHALLENGES) {
     const { solution, nonce } = req.body
+
     if (!solution || !nonce) {
       return res.status(400).send({
         status: "ERROR",
         message: "'solution', and 'nonce', fields are required",
       })
     }
 
-    if (!Number.isInteger(nonce)) {
+    if (!Number.isInteger(Number(nonce))) {
       return res.status(400).send({
         status: "ERROR",
         message: "'nonce' must be an integer",

diff --git a/src/pow.ts b/src/pow.ts
@@ -112,13 +112,13 @@ export const getChallenge = async (
   } satisfies ChallengeState as ChallengeState
 }
 
-const getSolution = (challenge: string, nonce: number) =>
+const getSolution = (challenge: string, nonce: number | string) =>
   createHash("sha256").update(`${challenge}:${nonce}`).digest("hex")
 
 interface VerifySolutionArgs {
   challenge: string
   difficulty: number
-  nonce: number
+  nonce: number | string
   solution: string
 }
 export const verifySolution = ({