Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transformer): move create_prototype_member to utils module #8657

Merged
merged 1 commit into from
Jan 22, 2025
Merged

refactor(transformer): move create_prototype_member to utils module #8657

merged 1 commit into from
Jan 22, 2025
+12 −15

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 22, 2025 •
edited
Loading

This function can also used in #8614, so move it.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 22, 2025
@Dunqing Dunqing changed the title refactor(transformer): move create_prototype_member to utils module refactor(transformer): move create_prototype_member to utils module Jan 22, 2025
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Jan 22, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 22, 2025
Open
Draft
@Dunqing Dunqing marked this pull request as ready for review January 22, 2025 14:25
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 22, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8657 will not alter performance

Comparing 01-22-refactor_transformer_move_create_prototype_member_to_utils_module (a730f99) with main (3802d28)

Summary

✅ 32 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 22, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Jan 22, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Jan 22, 10:50 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 22, 10:51 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 22, 10:56 AM EST: A user merged this pull request with the Graphite merge queue.

@overlookmotel overlookmotel force-pushed the 01-22-refactor_transformer_move_create_prototype_member_to_utils_module branch from a2a6454 to a730f99 Compare January 22, 2025 15:51
@graphite-app graphite-app bot merged commit a730f99 into main Jan 22, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-22-refactor_transformer_move_create_prototype_member_to_utils_module branch January 22, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dunqing @overlookmotel