Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(allocator): move Allocator into own module #8656

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 22, 2025

Pure refactor. oxc_allocator crate is getting quite crowded now. Move Allocator into a separate file.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Jan 22, 2025
Copy link
Contributor Author

overlookmotel commented Jan 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review January 22, 2025 13:03
@overlookmotel overlookmotel force-pushed the 01-22-refactor_allocator_move_allocator_into_own_module branch from 2145d4a to c20cb3b Compare January 22, 2025 13:10
@Boshen Boshen changed the base branch from 01-22-refactor_allocator_reduce_repeat_code_to_prevent_drop_types_in_arena to graphite-base/8656 January 22, 2025 13:18
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #8656 will not alter performance

Comparing 01-22-refactor_allocator_move_allocator_into_own_module (ae8db53) with main (0f85bc6)

Summary

✅ 32 untouched benchmarks

@Boshen Boshen force-pushed the 01-22-refactor_allocator_move_allocator_into_own_module branch from c20cb3b to 73d718e Compare January 22, 2025 13:24
@Boshen Boshen force-pushed the graphite-base/8656 branch from 0773f49 to 0f85bc6 Compare January 22, 2025 13:24
@Boshen Boshen changed the base branch from graphite-base/8656 to main January 22, 2025 13:25
@Boshen Boshen force-pushed the 01-22-refactor_allocator_move_allocator_into_own_module branch from 73d718e to 3188e2b Compare January 22, 2025 13:25
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 22, 2025
Copy link
Member

Boshen commented Jan 22, 2025

Merge activity

  • Jan 22, 8:45 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 22, 8:45 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 22, 8:50 AM EST: A user merged this pull request with the Graphite merge queue.

Pure refactor. `oxc_allocator` crate is getting quite crowded now. Move `Allocator` into a separate file.
@Boshen Boshen force-pushed the 01-22-refactor_allocator_move_allocator_into_own_module branch from 3188e2b to ae8db53 Compare January 22, 2025 13:45
@graphite-app graphite-app bot merged commit ae8db53 into main Jan 22, 2025
38 checks passed
@graphite-app graphite-app bot deleted the 01-22-refactor_allocator_move_allocator_into_own_module branch January 22, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants