refactor(isolated_declarations, linter, minifier, prettier, semantic, transformer): remove unnecessary ref / ref mut syntax
#8643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 21, 2025
github-actions
bot
added
A-linter
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
overlookmotel
requested review from
Dunqing,
Boshen and
leaysgur
as code owners
CodSpeed Performance ReportMerging #8643 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jan 21, 2025
Merge activity
|
… transformer): remove unnecessary `ref` / `ref mut` syntax (#8643) While working on #8641, I found a lot of places where we unnecessarily use `ref` / `ref mut` in match arms. In many cases, we're creating double-references (turning a `&T` into a `&&T`). The compiler should be smart enough to remove them for us, but there doesn't seem much point in explicitly creating double-references when we don't actually want them, and relying on compiler to optimize them out again.
Boshen
force-pushed
the
01-21-refactor_span_remove_partialeq_impl_for_atom_
branch
from
c83b9d1 to
54d0fac
Compare
Boshen
force-pushed
the
01-21-refactor_isolated_declarations_linter_minifier_prettier_semantic_transformer_remove_unnecessary_ref___ref_mut_syntax
branch
from
961b755 to
e66da9f
Compare
Base automatically changed from
01-21-refactor_span_remove_partialeq_impl_for_atom_
to
main
January 21, 2025 14:32
graphite-app
bot
deleted the
01-21-refactor_isolated_declarations_linter_minifier_prettier_semantic_transformer_remove_unnecessary_ref___ref_mut_syntax
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #8641, I found a lot of places where we unnecessarily use
ref/ref mutin match arms.In many cases, we're creating double-references (turning a
&Tinto a&&T). The compiler should be smart enough to remove them for us, but there doesn't seem much point in explicitly creating double-references when we don't actually want them, and relying on compiler to optimize them out again.