Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(transformer/arrow-function): create a new ident instead of clone #8338

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 8, 2025

There seems no reason to use a cloned identifier.

Copy link
Member Author

Dunqing commented Jan 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing marked this pull request as ready for review January 8, 2025 08:31
@Dunqing Dunqing requested a review from overlookmotel as a code owner January 8, 2025 08:31
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 8, 2025
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Merging #8338 will not alter performance

Comparing 01-08-refactor_transformer_arrow-function_create_a_new_ident_instead_of_clone (fb389f7) with main (8d52cd0)

Summary

✅ 29 untouched benchmarks

@Dunqing Dunqing force-pushed the 01-08-refactor_transformer_arrow-function_create_a_new_ident_instead_of_clone branch 2 times, most recently from f080e32 to 9977e1f Compare January 8, 2025 08:41
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 8, 2025
Copy link
Contributor

overlookmotel commented Jan 8, 2025

Merge activity

  • Jan 8, 2:41 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 8, 2:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Jan 8, 2:49 PM EST: A user merged this pull request with the Graphite merge queue.

…lone (#8338)

There seems no reason to use a cloned identifier.
@overlookmotel overlookmotel force-pushed the 01-08-refactor_transformer_arrow-function_create_a_new_ident_instead_of_clone branch from 51eb770 to fb389f7 Compare January 8, 2025 19:43
@graphite-app graphite-app bot merged commit fb389f7 into main Jan 8, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 01-08-refactor_transformer_arrow-function_create_a_new_ident_instead_of_clone branch January 8, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants