-
-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(transformer/arrow-functions): store super_methods
on a Stack
to fix nested async methods
#8331
Conversation
super_methods
to Stack
to fix nested async methods
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #8331 will not alter performanceComparing Summary
|
super_methods
to Stack
to fix nested async methodssuper_methods
on a Stack
to fix nested async methods
63f91ae
to
2788e89
Compare
2788e89
to
571a23e
Compare
Merge activity
|
…to fix nested async methods (#8331) In the following case, async methods can be nested in another async method. The implementation is changing to store `super_methods` on a stack, and then we can store super method information in the correct `super_methods` map. ```js const outer = { value: 0, async method() { () => super.value; const inner = { value: 0, async method() { () => super.value; } }; () => super.value; } }; ```
571a23e
to
e4d66e4
Compare
In the following case, async methods can be nested in another async method. The implementation is changing to store
super_methods
on a stack, and then we can store super method information in the correctsuper_methods
map.