Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer): remove repeated code from fixtures updating script #8287

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Jan 6, 2025

Pure refactor / tidy up. These 2 lines are repeated twice.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 6, 2025
@overlookmotel overlookmotel marked this pull request as ready for review January 6, 2025 11:45
@overlookmotel
Copy link
Contributor Author

Small and uncontroversial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Jan 6, 2025
Copy link
Contributor Author

overlookmotel commented Jan 6, 2025

Merge activity

  • Jan 6, 6:46 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 6, 6:50 AM EST: A user added this pull request to the Graphite merge queue.
  • Jan 6, 7:00 AM EST: A user merged this pull request with the Graphite merge queue.

…#8287)

Pure refactor / tidy up. These 2 lines are repeated twice.
@overlookmotel overlookmotel force-pushed the 01-01-test_transformer_remove_repeated_code_from_fixtures_updating_script branch from e8da5d2 to cd0c2dc Compare January 6, 2025 11:55
@graphite-app graphite-app bot merged commit cd0c2dc into main Jan 6, 2025
15 checks passed
@graphite-app graphite-app bot deleted the 01-01-test_transformer_remove_repeated_code_from_fixtures_updating_script branch January 6, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant