refactor(transformer/async-to-generator): pass TraverseCtx to function not AstBuilder
#8279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #8279 will not alter performanceComparing Summary
|
Dunqing
approved these changes
Jan 6, 2025
Merge activity
|
…ion not `AstBuilder` (#8279) Pure refactor. Our convention in transformer is to pass `TraverseCtx` around, and not deal with `AstBuilder` directly. This will make it easier to make changes to `AstBuilder` to support Node IDs later on.
Dunqing
force-pushed
the
01-04-refactor_transformer_async-to-generator_pass_traversectx_to_function_not_astbuilder_
branch
from
af0ddc0 to
a5e3528
Compare
graphite-app
bot
deleted the
01-04-refactor_transformer_async-to-generator_pass_traversectx_to_function_not_astbuilder_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure refactor. Our convention in transformer is to pass
TraverseCtxaround, and not deal withAstBuilderdirectly. This will make it easier to make changes toAstBuilderto support Node IDs later on.