fix(estree): make type of BigIntLiteral::raw prop in ESTree AST optional
#7663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Dec 5, 2024
overlookmotel
changed the title
BigIntLiteral::raw prop in ESTree optionalBigIntLiteral::raw prop in ESTree AST optional
CodSpeed Performance ReportMerging #7663 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
12-05-fix_estree_raw_null_in_estree_ast_for_generated_nullliteral_s
branch
from
58e33b8 to
f66b55c
Compare
overlookmotel
force-pushed
the
12-05-fix_estree_make_type_of_bigintliteral_raw_prop_in_estree_optional
branch
from
883208c to
a8c61c6
Compare
Dunqing
approved these changes
Dec 5, 2024
Merge activity
|
…ional (#7663) `BigIntLiteral`'s `raw` field is not an `Option` on Rust side, but this is an internal implementation detail - we may parse bigints to a `BigInt` in future (as we did in the past before we hit a memory leak problem), and make `raw` an `Option`. So at present, the `raw` field is always non-null in JS-side AST. But update the TS type def to reflect that it should be an optional property. This aligns with ESTree.
Dunqing
force-pushed
the
12-05-fix_estree_raw_null_in_estree_ast_for_generated_nullliteral_s
branch
from
f66b55c to
cbba26c
Compare
Dunqing
force-pushed
the
12-05-fix_estree_make_type_of_bigintliteral_raw_prop_in_estree_optional
branch
from
a8c61c6 to
2179b93
Compare
Base automatically changed from
12-05-fix_estree_raw_null_in_estree_ast_for_generated_nullliteral_s
to
main
December 5, 2024 04:11
graphite-app
bot
deleted the
12-05-fix_estree_make_type_of_bigintliteral_raw_prop_in_estree_optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigIntLiteral'srawfield is not anOptionon Rust side, but this is an internal implementation detail - we may parse bigints to aBigIntin future (as we did in the past before we hit a memory leak problem), and makerawanOption.So at present, the
rawfield is always non-null in JS-side AST. But update the TS type def to reflect that it should be an optional property. This aligns with ESTree.