Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): rename is_same_reference to is_same_expression #7654

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Dec 4, 2024

No description provided.

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Dec 4, 2024
Copy link
Contributor Author

camc314 commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 4, 2024 21:25
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7654 will not alter performance

Comparing c/12-04-refactor_linter_rename_is_same_reference_to_is_same_expression_ (3711a8e) with main (2179b93)

Summary

✅ 29 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Dec 5, 2024

Can this be replaced by ContentEqual?

Edit: I replaced it with left.content_eq(right) but a bunch of tests failed. May need to replace it case by case :-(

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Dec 5, 2024
Copy link
Member

Boshen commented Dec 5, 2024

Merge activity

  • Dec 4, 11:07 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Dec 4, 11:07 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 11:22 PM EST: A user merged this pull request with the Graphite merge queue.

@Boshen Boshen force-pushed the c/12-04-refactor_linter_rename_is_same_reference_to_is_same_expression_ branch from fa60a2c to 3711a8e Compare December 5, 2024 04:15
@graphite-app graphite-app bot merged commit 3711a8e into main Dec 5, 2024
24 checks passed
@graphite-app graphite-app bot deleted the c/12-04-refactor_linter_rename_is_same_reference_to_is_same_expression_ branch December 5, 2024 04:22
@camc314
Copy link
Contributor Author

camc314 commented Dec 5, 2024

Can this be replaced by ContentEqual?

Edit: I replaced it with left.content_eq(right) but a bunch of tests failed. May need to replace it case by case :-(

yeah this one is a little looser than content_eq

@oxc-bot oxc-bot mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants