Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): print parentheses correctly for ClassHeritage #7637

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Dec 4, 2024

closes #7631

Copy link

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

Boshen commented Dec 4, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-codegen Area - Code Generation C-bug Category - Bug labels Dec 4, 2024
Copy link

graphite-app bot commented Dec 4, 2024

Merge activity

@Boshen Boshen force-pushed the 12-04-fix_codegen_print_parentheses_correctly_for_classheritage branch from 5926d47 to e787e9d Compare December 4, 2024 06:43
@graphite-app graphite-app bot merged commit e787e9d into main Dec 4, 2024
24 checks passed
@graphite-app graphite-app bot deleted the 12-04-fix_codegen_print_parentheses_correctly_for_classheritage branch December 4, 2024 06:48
Copy link

codspeed-hq bot commented Dec 4, 2024

CodSpeed Performance Report

Merging #7637 will not alter performance

Comparing 12-04-fix_codegen_print_parentheses_correctly_for_classheritage (e787e9d) with main (d2767be)

Summary

✅ 29 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation C-bug Category - Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen: Unnecessary parentheses in extends class of class
1 participant