Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

up(cli): support --version #2154

Closed
wants to merge 1 commit into from
Closed

up(cli): support --version #2154

wants to merge 1 commit into from

Conversation

DonIsaac
Copy link
Contributor

Adds support for --version to all commands in oxc_cli. I've set oxc_cli's version to match the other packages in the monorepo (0.5.0). Let me know if you'd like the version set to some other value.

@DonIsaac DonIsaac added C-enhancement Category - New feature or request A-cli Area - CLI labels Jan 23, 2024
Copy link

codspeed-hq bot commented Jan 23, 2024

CodSpeed Performance Report

Merging #2154 will not alter performance

Comparing don/cli/up/version (4ed908d) with main (1ee6d8c)

Summary

✅ 17 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jan 24, 2024

The version should match

"version": "0.2.4",

I think we need to compile it into the binary by supplying it in CI

version: ${{ needs.check.outputs.version }}

Boshen added a commit that referenced this pull request Jan 26, 2024
@Boshen Boshen mentioned this pull request Jan 26, 2024
@Boshen Boshen closed this in #2182 Jan 26, 2024
Boshen added a commit that referenced this pull request Jan 26, 2024
@Boshen Boshen deleted the don/cli/up/version branch March 25, 2024 09:35
IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area - CLI C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants