Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): eslint-plugin-react-perf #2086

Merged
merged 11 commits into from
Jan 22, 2024
Merged

feat(linter): eslint-plugin-react-perf #2086

merged 11 commits into from
Jan 22, 2024

Conversation

byteHulk
Copy link
Contributor

@byteHulk byteHulk commented Jan 19, 2024 •
edited by camc314
Loading

Related Issue

#2041

Closes #2042 #2043 #2044 #2045

@github-actions github-actions bot added the A-linter Area - Linter label Jan 19, 2024
@byteHulk byteHulk changed the title Feat/linter eslint plugin react perf feat(linter): eslint-plugin-react-perf Jan 19, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 19, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #2086 will not alter performance

Comparing byteHulk:feat/linter-eslint-plugin-react-perf (a873362) with main (2228aa8)

Summary

✅ 17 untouched benchmarks

@Boshen
Copy link
Member

Boshen commented Jan 19, 2024

This is huge! Thank you in advance!

@byteHulk byteHulk requested a review from Boshen January 20, 2024 04:03
@byteHulk byteHulk requested a review from camc314 January 22, 2024 02:50
Boshen
Boshen reviewed Jan 22, 2024
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a big addition, can you help out and test these rules in big repositories?

You may follow the instructions help https://github.com/oxc-project/oxc/blob/main/MAINTENANCE.md#release-linter

@byteHulk
Copy link
Contributor Author

由于这是一个很大的补充，您可以帮助在大型仓储库中测试这些规则吗？

您可以按照说明帮助https://github.com/oxc-project/oxc/blob/main/MAINTENANCE.md#release-linter

okay

@byteHulk
Copy link
Contributor Author

由于这是一个很大的补充，您可以帮助在大型车库中测试这些规则吗？

您可以按照说明帮助https://github.com/oxc-project/oxc/blob/main/MAINTENANCE.md#release-linter

I tested these repositories and they all work fine, some of them have lint warnings(It's normal, right?).
@Boshen

@Boshen Boshen merged commit 5ca07bc into oxc-project:main Jan 22, 2024
16 checks passed
@Boshen
Copy link
Member

Boshen commented Jan 22, 2024

Thank you so much for working on this! Much appreciated.

IWANABETHATGUY pushed a commit to IWANABETHATGUY/oxc that referenced this pull request May 29, 2024
@byteHulk @IWANABETHATGUY
feat(linter): eslint-plugin-react-perf (oxc-project#2086)
0a50a7a 
Relates oxc-project#2041 

Closes oxc-project#2042
Closes oxc-project#2043
Closes oxc-project#2044
Closes oxc-project#2045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen left review comments

@camc314 camc314 Awaiting requested review from camc314

Assignees
No one assigned
Labels
A-linter Area - Linter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(linter): react-perf/jsx-no-jsx-as-props
3 participants
@byteHulk @Boshen @camc314