Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for etag propagation sharing with groups #137

Merged
merged 2 commits into from
Nov 25, 2015

Conversation

jvillafanez
Copy link
Member

Completing #136 with group sharing.

The flow is the same, sharing with groups instead of users. The check for the etag propagation is done for all the members of the group (registered in the group_map)

Basic setup includes one owner who doesn't belong to any group, and 4 groups each one with 2 users. It's possible to add more test cases by adding more users to the group_map, but probably not worthy.

There is one server issue found (I'll open it soon) for 8.2.1, also reproducible manually. I haven't tested with @icewind1991 's patch

@nickvergessen @PVince81 @DeepDiver1975

Note: I've tested with the sleeps from #136 but removed them before uploading the code.

for user in group_map[group]:
add_user_to_group(get_account_name(user), group)

reset_rundir()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove everthing from here reset_rundir() down to the end of the worker, smashbox takes care of that:
79006cb

@nickvergessen
Copy link

Fixed my comments, tests are fine and pass (with owncloud/core#20439 )

👍

@PVince81 review/test

@PVince81
Copy link

👍

PVince81 pushed a commit that referenced this pull request Nov 25, 2015
Added tests for etag propagation sharing with groups
@PVince81 PVince81 merged commit 2542713 into master Nov 25, 2015
@PVince81 PVince81 deleted the share_propagation_tests_groups branch November 25, 2015 10:21
@DeepDiver1975
Copy link
Member

jenkins job for initial testing: https://ci.owncloud.org/job/smashbox-on-docker-ci/18/

@DeepDiver1975
Copy link
Member

why are these tests in lib/owncloud and not lib/oc-tests

@nickvergessen
Copy link

we use owncloud/ for our tests, oc-tests/ are the tests from cern which we shouldn't touch directly

@DeepDiver1975
Copy link
Member

execution of the test on jenkins fails @nickvergessen mind having a look? THX

https://ci.owncloud.org/job/smashbox-on-docker-ci/20/DOCKER_IMAGE=ubuntu_oc_lamp-git,TEST_NAME=test_sharePropagationInsideGroups,mirallBranch=v1.8.3,slave=SMASH/console

00:03:54.468 ********************************************************************************
00:03:54.468 (14) owner:  VERIFY ETAG PROPAGATION
00:03:54.468 ********************************************************************************
00:03:54.507 2015-11-25 15:02:51,126 - ERROR - owner - recipient 4 uploads to /sub/test6.txt through reshare etag for / previous ["565613ea2b815"] new ["565613ea2b815"] 'etag for / previous [%s] new [%s]' % (root_etag5, root_etag6)) failed in owner() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 176]
00:03:54.509 2015-11-25 15:02:51,127 - ERROR - owner - recipient 4 uploads to /sub/test6.txt through reshare etag for /test previous ["565613ea21489"] new ["565613ea21489"] 'etag for /test previous [%s] new [%s]' % (test_etag3, test_etag4)) failed in owner() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 178]
00:03:54.551 2015-11-25 15:02:51,168 - ERROR - recipient1 - recipient 4 uploads to /sub/test6.txt through reshare etag for / previous [['"ffa3335290732cdde493ea859b9dc595"', '"c5c22269b036c9e8f12cd07a81b0e474"']] new [['"ffa3335290732cdde493ea859b9dc595"', '"c5c22269b036c9e8f12cd07a81b0e474"']] 'etag for / previous [%s] new [%s]' % (root_etags5, root_etags6)) failed in recipient1() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 246]
00:03:54.552 2015-11-25 15:02:51,168 - ERROR - recipient3 - recipient 4 uploads to /sub/test6.txt through reshare etag for / previous [['"80d29419bec3f7825f74c3a5919a8ff9"', '"1c9631de0e6b65ddb5d4bde9f576c1b0"']] new [['"80d29419bec3f7825f74c3a5919a8ff9"', '"1c9631de0e6b65ddb5d4bde9f576c1b0"']] 'etag for / previous [%s] new [%s]' % (root_etags5, root_etags6)) failed in recipient3() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 396]
00:03:54.552 2015-11-25 15:02:51,168 - ERROR - recipient1 - recipient 4 uploads to /sub/test6.txt through reshare etag for /test previous [['"565613ea21489"', '"565613ea21489"']] new [['"565613ea21489"', '"565613ea21489"']] 'etag for /test previous [%s] new [%s]' % (test_etags3, test_etags4)) failed in recipient1() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 248]
00:03:54.553 2015-11-25 15:02:51,168 - ERROR - recipient3 - recipient 4 uploads to /sub/test6.txt through reshare etag for /test previous [['"565613ea21489"', '"565613ea21489"']] new [['"565613ea21489"', '"565613ea21489"']] 'etag for /test previous [%s] new [%s]' % (test_etags3, test_etags4)) failed in recipient3() ["/ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashbox/lib/owncloud/test_sharePropagationInsideGroups.py" at line 398]
00:03:54.580 2015-11-25 15:02:51,198 - INFO - owner - entering new step 
00:03:54.580 ********************************************************************************
00:03:54.580 (16) owner:  VERIFY ETAG IS NOT PROPAGATED
00:03:54.580 ********************************************************************************
00:03:54.580 2015-11-25 15:02:51,199 - INFO - recipient1 - entering new step 
00:03:54.580 ********************************************************************************
00:03:54.580 (16) recipient1:  VERIFY ETAG PROPAGATION
00:03:54.580 ********************************************************************************
00:03:54.580 2015-11-25 15:02:51,199 - INFO - recipient3 - entering new step 
00:03:54.580 ********************************************************************************
00:03:54.580 (16) recipient3:  VERIFY ETAG PROPAGATION
00:03:54.580 ********************************************************************************

00:03:55.566 2015-11-25 15:02:52,184 - ERROR - owner - 3 error(s) reported
00:03:55.572 2015-11-25 15:02:52,186 - ERROR - recipient1 - 3 error(s) reported
00:03:55.578 2015-11-25 15:02:52,191 - ERROR - recipient3 - 3 error(s) reported
00:03:55.578 2015-11-25 15:02:52,196 - INFO - supervisor - running 'mkdir -p /ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashdir/test_sharePropagationInsideGroups/supervisor'
00:03:55.583 2015-11-25 15:02:52,199 - INFO - supervisor - make_workdir /ssd/jenkins/workspace/smashbox-on-docker-ci/DOCKER_IMAGE/ubuntu_oc_lamp-git/TEST_NAME/test_sharePropagationInsideGroups/mirallBranch/v1.8.3/slave/SMASH/smashdir/test_sharePropagationInsideGroups/supervisor
00:03:55.597 SUMMARY:smash.:Elapsed time: 46s (0:00:46.377517)
00:03:55.597 CRITICAL:smash.:Aborting run -- non-zero exit code (2)
00:03:55.604 Kill the docker 9d4c38cfb5b76946ba63662912b23fb65675ba1d695d4a9db9125718bd441547

00:03:56.629 9d4c38cfb5b76946ba63662912b23fb65675ba1d695d4a9db9125718bd441547
00:03:56.880 Build step 'Execute shell' marked build as failure

00:03:57.583 Setting commit status on GitHub for https://github.com/owncloud/core/commit/906aea4252c2ee6a33f7ba47388e3b290677b2df
00:03:57.827 Finished: FAILURE

@nickvergessen
Copy link

Still using client 1.8?

Will have a look using that tomorrow

@DeepDiver1975
Copy link
Member

1.8 yes

Thx

@nickvergessen
Copy link

Theres a 403 on resharing the file, maybe that is related to your docker image, waiting for maci

@DeepDiver1975
Copy link
Member

waiting for maci

@jmaciasportela

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants