-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests for etag propagation sharing with groups #137
Conversation
for user in group_map[group]: | ||
add_user_to_group(get_account_name(user), group) | ||
|
||
reset_rundir() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove everthing from here reset_rundir()
down to the end of the worker, smashbox takes care of that:
79006cb
Fixed my comments, tests are fine and pass (with owncloud/core#20439 ) 👍 @PVince81 review/test |
👍 |
Added tests for etag propagation sharing with groups
jenkins job for initial testing: https://ci.owncloud.org/job/smashbox-on-docker-ci/18/ |
why are these tests in lib/owncloud and not lib/oc-tests |
we use owncloud/ for our tests, oc-tests/ are the tests from cern which we shouldn't touch directly |
execution of the test on jenkins fails @nickvergessen mind having a look? THX
|
Still using client 1.8? Will have a look using that tomorrow |
1.8 yes Thx |
Theres a 403 on resharing the file, maybe that is related to your docker image, waiting for maci |
|
Completing #136 with group sharing.
The flow is the same, sharing with groups instead of users. The check for the etag propagation is done for all the members of the group (registered in the group_map)
Basic setup includes one owner who doesn't belong to any group, and 4 groups each one with 2 users. It's possible to add more test cases by adding more users to the group_map, but probably not worthy.
There is one server issue found (I'll open it soon) for 8.2.1, also reproducible manually. I haven't tested with @icewind1991 's patch
@nickvergessen @PVince81 @DeepDiver1975
Note: I've tested with the sleeps from #136 but removed them before uploading the code.