Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 32012 - read the correct translations #32015

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 9, 2018

Description

Read translations from the correct location

Related Issue

How Has This Been Tested?

Screenshots (if appropriate):

  • manually: open settings and see the real language names not the codes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@DeepDiver1975 DeepDiver1975 added this to the QA milestone Jul 9, 2018
@DeepDiver1975 DeepDiver1975 self-assigned this Jul 9, 2018
@DeepDiver1975
Copy link
Member Author

backport is in open PR - b669a73

@phil-davis
Copy link
Contributor

works 👍

@DeepDiver1975 DeepDiver1975 requested a review from VicDeo July 9, 2018 07:51
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #32015 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #32015      +/-   ##
============================================
+ Coverage     63.58%   63.58%   +<.01%     
  Complexity    18553    18553              
============================================
  Files          1169     1169              
  Lines         69604    69604              
  Branches       1264     1264              
============================================
+ Hits          44259    44260       +1     
+ Misses        24976    24975       -1     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.59% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.84% <100%> (ø) 18553 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Helper/LocaleHelper.php 100% <100%> (+2.63%) 15 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69b1d49...8f94efa. Read the comment docs.

@phil-davis phil-davis merged commit 42a11fe into master Jul 9, 2018
@phil-davis phil-davis deleted the bugfix/32012 branch July 9, 2018 08:41
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Personal language selection broken in core master
3 participants