Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webDAV acceptance tests for upload-download-propfind of unusual file names #32010

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Add acceptance tests that check upload, download and propfind via webDAV of files that have unusual names (regular ASCII, European special characters, other Unicode script, characters special to URLs like #?

Related Issue

#32009
The tests cover some more combinations that might have been causing a problem for that issue. But actually these tests all pass.

Motivation and Context

Have a broader range of webDAV tests that check functionality with typical subsets of characters used in file and folder names.

How Has This Been Tested?

  • run acceptance tests locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • N/A Unit tests added
  • [ x Acceptance tests added
  • N/A Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis added this to the development milestone Jul 9, 2018
@phil-davis phil-davis self-assigned this Jul 9, 2018
@phil-davis phil-davis changed the title Add webDAV acceptance tests for upload-download-propfind of unusualile names Add webDAV acceptance tests for upload-download-propfind of unusual file names Jul 9, 2018
@phil-davis
Copy link
Contributor Author

phil-davis commented Jul 9, 2018

~~CI fail due to issue #32012 ~~
rebased as master is now fixed

@phil-davis phil-davis force-pushed the webDAV-unusual-filename-test branch from 53eff32 to 96108bf Compare July 9, 2018 08:44
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #32010 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #32010      +/-   ##
============================================
+ Coverage     63.44%   63.58%   +0.14%     
  Complexity    18553    18553              
============================================
  Files          1169     1169              
  Lines         69604    69604              
  Branches       1264     1264              
============================================
+ Hits          44157    44261     +104     
+ Misses        25078    24974     -104     
  Partials        369      369
Flag Coverage Δ Complexity Δ
#javascript 52.59% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.84% <ø> (+0.16%) 18553 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/View.php 84.47% <0%> (+0.3%) 396% <0%> (ø) ⬇️
lib/private/Repair/RepairMismatchFileCachePath.php 85.54% <0%> (+0.39%) 51% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.48%) 68% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaManager.php 91.22% <0%> (+1.75%) 17% <0%> (ø) ⬇️
lib/private/DB/Connection.php 68.38% <0%> (+4.41%) 49% <0%> (ø) ⬇️
...private/DB/MySqlSchemaColumnDefinitionListener.php 5.35% <0%> (+5.35%) 46% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 93.75% <0%> (+6.25%) 34% <0%> (ø) ⬇️
lib/private/DB/ConnectionFactory.php 82.19% <0%> (+9.58%) 20% <0%> (ø) ⬇️
lib/private/DB/AdapterMySQL.php 50% <0%> (+50%) 4% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a11fe...96108bf. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #32016

@phil-davis phil-davis merged commit 6303095 into master Jul 9, 2018
@phil-davis phil-davis deleted the webDAV-unusual-filename-test branch July 9, 2018 09:39
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants