[8.2] Group share etag propagation #21044
Conversation
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975, @PVince81 and @LukasReschke to be potential reviewers |
| @@ -411,7 +341,7 @@ public function testRecipientUploadInDirectReshare() { | |||
| $this->assertEtagsNotChanged([self::TEST_FILES_SHARING_API_USER3]); | |||
| $this->assertEtagsChanged([self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER4]); | |||
|
|
|||
| $this->assertAllUnchaged(); | |||
| $this->assertAllUnchanged(); | |||
There was a problem hiding this comment.
looks like this will have to be forward ported to master too
There was a problem hiding this comment.
fixing a method name... of tests... in a maintenance branch ....
|
Thanks a lot! I guess the new unit tests should later be ported to master as well for additional benefit. |
|
I'm having problems reproducing the propagation problem from the original issue |
|
Ok, I managed to reproduce a failure by re-sharing a subfolder with a group |
icewind1991
force-pushed
the
group-propagation-82
branch
from
d90165b to
f72db4e
Compare
|
Ok, fixed the problem, ready for review |
|
Smashbox still failing on CI for some reason ? |
|
One less failure at least |
|
I cherry picked locally #20949 (backport pending) to make sure the test actually pass. 👍 |
|
@karlitschek please approve this non-backport for 8.2.2. This is a 8.2 specific fix for etag propagation for groups. The 9.0 fix is different and cannot be backported as is. |
|
Needs a second reviewer @MorrisJobke @jvillafanez @DeepDiver1975 @nickvergessen @rullzer @schiesbn |
|
please backport 👍 |
|
awesome! Looks good and seems to fix the issue. 👍 |
[8.2] Group share etag propagation
|
@icewind1991 can you forward port the unit test ? |
For #20714
Currently only unit test for it