Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mimetype filter in getDirectoryContent #20904

Merged
merged 1 commit into from
Dec 7, 2015
Merged

Fix mimetype filter in getDirectoryContent #20904

merged 1 commit into from
Dec 7, 2015

Conversation

icewind1991
Copy link
Contributor

Added tests to keep it working in the future

Fixes #20899

cc @PVince81 @Xenopathic

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @bartv2, @LukasReschke and @PVince81 to be potential reviewers

@icewind1991 icewind1991 mentioned this pull request Dec 2, 2015
Closed
@icewind1991 icewind1991 added this to the 9.0-current milestone Dec 2, 2015
@LukasReschke
Copy link
Member 

10:50:36 There were 2 failures:
10:50:36 
10:50:36 1) Test\Files\View::testMountPointMove
10:50:36 Can rename mount point
10:50:36 Failed asserting that false is true.
10:50:36 
10:50:36 /ssd/jenkins/workspace/server-master-linux-php7-ci@2/database/sqlite/label/SLAVE/tests/lib/files/view.php:1575
10:50:36 
10:50:36 2) Test\Files\View::testLockMoveMountPoint
10:50:36 Source path locked properly during operation
10:50:36 Failed asserting that null matches expected 2.
10:50:36 
10:50:36 /ssd/jenkins/workspace/server-master-linux-php7-ci@2/database/sqlite/label/SLAVE/tests/lib/files/view.php:2265
10:50:36

@RobinMcCorkell
Copy link
Member

Wtf how did that code even work originally?! 👍 for sure (after tests are fixed)

EDIT: Oh, it didn't, it was broken in #20439

@icewind1991
Copy link
Contributor Author

all fixed

@PVince81
Copy link
Contributor

PVince81 commented Dec 4, 2015

👍 (failing OCS test unrelated)

DeepDiver1975 added a commit that referenced this pull request Dec 7, 2015
@DeepDiver1975
Merge pull request #20904 from owncloud/view-mime-filter
0c3d979 
Fix mimetype filter in getDirectoryContent
@DeepDiver1975 DeepDiver1975 merged commit 0c3d979 into master Dec 7, 2015
@DeepDiver1975 DeepDiver1975 deleted the view-mime-filter branch December 7, 2015 09:20
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
4 - To release comp:filesystem
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

\OCA\Files\Helper::getFiles() $filter does not work properly in master
6 participants
@icewind1991 @mention-bot @LukasReschke @RobinMcCorkell @PVince81 @DeepDiver1975