Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sabre patch for recursive PROPFIND and "0" folders #176

Closed
wants to merge 1 commit into from
Closed

Sabre patch for recursive PROPFIND and "0" folders #176

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

@PVince81
Copy link
Contributor Author

Fixes PROPFIND issue discovered here owncloud/client#3351 (comment)

@PVince81
Copy link
Contributor Author

(but does not fix the upload issue in that ticket)

@nickvergessen
Copy link
Contributor

odd, should add a smashbox test for folders and files named 0 I guess?

@PVince81
Copy link
Contributor Author

@nickvergessen see owncloud/smashbox#114
not sure if it's worth writing a completely separate lonely test for that.

@PVince81 PVince81 force-pushed the sabre-concatzerofolderpatch branch from 6d8e2cb to d47edbb Compare June 17, 2015 18:44
@PVince81
Copy link
Contributor Author

PVince81 commented Jul 7, 2015

Upstream patch https://github.com/fruux/sabre-dav/pull/677 was merged.

We'll still need to patch the local library until we upgrade to next Sabre version, probably 3.0.2 once it's out...

@DeepDiver1975
Copy link
Contributor

We can also wait for 2.1.5 being released - fruux/sabre-dav@d64aa40

@PVince81
Copy link
Contributor Author

PVince81 commented Jul 7, 2015

Ah nice, I didn't see any backport notice. Maybe they don't do it like we do 😄

@DeepDiver1975
Copy link
Contributor

Maybe they don't do it like we do 😄

No 😉 - Evert just merged the changes to all release branches

@jakobsack
Copy link

Patch integrated in Sabre 2.1.6, merged in #187 and #188

@jakobsack jakobsack closed this Jul 22, 2015
@DeepDiver1975 DeepDiver1975 deleted the sabre-concatzerofolderpatch branch July 22, 2015 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @nickvergessen @DeepDiver1975 @jakobsack