Signal #580
Merged
Signal #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
reviewed
Mar 30, 2021
ryanrhymes
approved these changes
Mar 30, 2021
|
Great work! As @mseri commented, it would be great to have an mli file. |
tachukao
reviewed
Mar 31, 2021
|
Please do verify the updates. We have altered the tests and added an MLI file. Happy to make changes as needed. Thanks. |
|
Looks very good to me. @mseri comments? |
|
Looks great to me. I would suggest extending this module to both single and double precision, but that can be revised in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our initial attempt to address issue #564.