-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: infer package manager from container exec and set package as an interface #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musdotdigital
changed the title
feat/upgrade with docker dep
feat: handle ubuntu images and multiple argument pkgs
Nov 29, 2023
musdotdigital
changed the title
feat: handle ubuntu images and multiple argument pkgs
feat: handle ubuntu images and package as an interface
Nov 30, 2023
musdotdigital
changed the title
feat: handle ubuntu images and package as an interface
feat: infer package manager from container exec and set package as an interface
Nov 30, 2023
mblottiere
reviewed
Nov 30, 2023
mblottiere
reviewed
Dec 1, 2023
AlexandrePicosson
approved these changes
Dec 4, 2023
This probably deserves a v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We strip reliance on parsing dockerfile to determine the package manager, we now execute the container in order to determine the package manager to use. This mean that we can support a wider range of dockerfiles without needing custom logic added.
A quick change to use
package
as an interface as opposed to a class is cleaner in implementation and provided a nice downstream feature to the updater. We can now parse multiple keys from the dependency, while continuing to only be concerned withname
andversion
. As dependency manifests containing extra keys are not overwritten by the updater, we can now support declarations such as this:In this PR we also provide support for ubuntu flavoured images such as the
nvidia/cuda
.How to test
npm run build && npm run test
You can test this with different images by providing a new dockerfile and dependency to main.test.ts, for example I tested this for the an nvidia image with
and updating
dependencies.json
to: