feat: test for unsupported pkg manager

owkin · Nov 30, 2023 · cff1066 · cff1066
1 parent 13cdecb
commit cff1066
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 13 deletions.
diff --git a/__tests__/data/InvalidDockerfile b/__tests__/data/InvalidDockerfile
@@ -1 +1 @@
-RUN
+FROM centos:latest
diff --git a/__tests__/dockerfile.test.ts b/__tests__/dockerfile.test.ts
@@ -5,7 +5,7 @@ import {load} from '../src/dockerfile'
 test('load invalid dockerfile', async () => {
   let dockerfilePath = path.join(__dirname, 'data', 'InvalidDockerfile')
   await expect(load(dockerfilePath)).rejects.toThrow(
-    'Unable to extract image from Dockerfile'
+    'Unable to find supported package manager'
   )
 })
 

diff --git a/dist/index.js b/dist/index.js
@@ -74,7 +74,12 @@ function load(dockerfile) {
     return __awaiter(this, void 0, void 0, function* () {
         const content = fs_1.default.readFileSync(dockerfile).toString('utf-8');
         const extractedImage = extract_docker_image(content);
-        yield extractedImage.init_package_manager();
+        try {
+            yield extractedImage.init_package_manager();
+        }
+        catch (error) {
+            return Promise.reject(error);
+        }
         return extractedImage;
     });
 }
@@ -86,11 +91,8 @@ function extract_docker_image(dockerfile_content) {
         if (line.includes('FROM')) {
             imageName = line.split(' ')[1].trim();
         }
-        if (line.includes('apk add') || line.includes('apt-get install')) {
-            return new image.Image(imageName);
-        }
     }
-    throw Error('Unable to extract image from Dockerfile');
+    return new image.Image(imageName);
 }
 
 

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/dockerfile.ts b/src/dockerfile.ts
@@ -4,7 +4,11 @@ import fs from 'fs'
 export async function load(dockerfile: string): Promise<image.Image> {
   const content = fs.readFileSync(dockerfile).toString('utf-8')
   const extractedImage = extract_docker_image(content)
-  await extractedImage.init_package_manager()
+  try {
+    await extractedImage.init_package_manager()
+  } catch (error) {
+    return Promise.reject(error)
+  }
   return extractedImage
 }
 
@@ -15,9 +19,6 @@ function extract_docker_image(dockerfile_content: string): image.Image {
     if (line.includes('FROM')) {
       imageName = line.split(' ')[1].trim()
     }
-    if (line.includes('apk add') || line.includes('apt-get install')) {
-      return new image.Image(imageName)
-    }
   }
-  throw Error('Unable to extract image from Dockerfile')
+  return new image.Image(imageName)
 }