Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (discrete bar) hide horizontal axis #4371

Merged
merged 3 commits into from
Jan 3, 2025

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 2, 2025

Drops axis grid lines and labels for all discrete bar charts. The axis is currently only shown for discrete bar charts in relative mode, but relative mode is not supported for discrete bar charts.


This is part 1 of 2 in a stack made with GitButler:

@sophiamersmann sophiamersmann force-pushed the discrete-bar-hide-axis branch 2 times, most recently from 42f4c02 to f73c77e Compare January 2, 2025 15:15
@owidbot
Copy link
Contributor

owidbot commented Jan 2, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-discrete-bar-hide-axis

SVG tester:

Number of differences (default views): 4 (220e75) ❌
Number of differences (all views): 230 (48a4b5) ❌

Edited: 2025-01-03 10:00:54 UTC
Execution time: 1.28 seconds

@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 2, 2025
@sophiamersmann sophiamersmann force-pushed the discrete-bar-hide-axis branch from f73c77e to 9fdb051 Compare January 2, 2025 16:00
@sophiamersmann sophiamersmann marked this pull request as ready for review January 3, 2025 12:32
@sophiamersmann sophiamersmann merged commit 0fbc2ea into master Jan 3, 2025
8 checks passed
@sophiamersmann sophiamersmann deleted the discrete-bar-hide-axis branch January 3, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants