💄 override some of the worst non-collapsing margin offenders #4172

danyx23 · 2024-11-15T11:20:50Z

No description provided.

owidbot · 2024-11-15T11:37:59Z

Quick links (staging server):

Site	Admin	Wizard	Docs

Login: ssh owid@staging-site-grid-margin-tweaks-for-articles

Site-screenshots: https://github.com/owid/site-screenshots/compare/grid-margin-tweaks-for-articles
SVG tester: https://github.com/owid/owid-grapher-svgs/compare/grid-margin-tweaks-for-articles

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-11-15 11:37:59 UTC
Execution time: 1.24 seconds

ikesau

Would love to circle back around and do this systematically with CSS variables and all, but this is a good improvement nonetheless.

danyx23 · 2024-11-19T20:13:28Z

Nov 19, 3:13 PM EST: A user started a stack merge that includes this pull request via Graphite.
Nov 19, 3:14 PM EST: Graphite rebased this pull request as part of a merge.
Nov 19, 3:15 PM EST: A user merged this pull request with Graphite.

github-actions bot assigned danyx23 Nov 15, 2024

danyx23 mentioned this pull request Nov 15, 2024

💄 inset bullet points a little bit from the left #4173

Merged

danyx23 marked this pull request as ready for review November 15, 2024 16:42

danyx23 requested a review from ikesau November 15, 2024 16:42

ikesau approved these changes Nov 19, 2024

View reviewed changes

danyx23 added 2 commits November 19, 2024 20:13

💄 override some of the worst non-collapsing margin offenders

cfbc1d2

💄 tidy css

736ec6b

danyx23 force-pushed the grid-margin-tweaks-for-articles branch from 4199f59 to 736ec6b Compare November 19, 2024 20:13

danyx23 merged commit 858faeb into master Nov 19, 2024
14 of 16 checks passed

danyx23 deleted the grid-margin-tweaks-for-articles branch November 19, 2024 20:15

Provide feedback