-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Render thumbnails for graphers by uuid #3880
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2024-08-19 15:15:55 UTC |
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 19, 2024 14:59
28327df
to
e5c06a1
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 19, 2024 14:59
b754a9f
to
265637f
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 21, 2024 10:17
e5c06a1
to
57c64eb
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 10:17
265637f
to
91f193d
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 21, 2024 11:03
57c64eb
to
8d270f1
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 11:03
91f193d
to
41b9260
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 21, 2024 12:54
8d270f1
to
7c74a5b
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 12:54
41b9260
to
1dd7bdb
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 21, 2024 15:09
7c74a5b
to
1c77908
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 15:09
1dd7bdb
to
019831b
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 21, 2024 15:17
1c77908
to
29146e2
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 21, 2024 15:17
019831b
to
b96dde4
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 22, 2024 15:52
29146e2
to
9e8ac98
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 15:53
b96dde4
to
9490433
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 15:56
9490433
to
6d5c3bc
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 22, 2024 17:12
9e8ac98
to
30eb978
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 22, 2024 17:12
6d5c3bc
to
b6d10f1
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 23, 2024 11:21
30eb978
to
9a5e0e5
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 23, 2024 11:21
b6d10f1
to
6189190
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
August 26, 2024 20:45
9a5e0e5
to
ac04f5c
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
August 26, 2024 20:46
6189190
to
845c2ab
Compare
This was referenced Aug 26, 2024
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 9, 2024 09:33
2b29a3a
to
e287fc3
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 9, 2024 11:53
b837314
to
dd90777
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 9, 2024 11:53
e287fc3
to
940738b
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 9, 2024 14:44
dd90777
to
54273d0
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 9, 2024 14:45
940738b
to
0df5bff
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 07:59
54273d0
to
7e42ffd
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 07:59
0df5bff
to
2a74086
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 08:06
7e42ffd
to
de9ef7a
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 08:06
2a74086
to
fa93186
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 09:56
de9ef7a
to
02ef8d3
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 09:56
fa93186
to
8152321
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 10:24
02ef8d3
to
9088888
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:24
8152321
to
2163513
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 10:35
9088888
to
5538fc3
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:35
2163513
to
dd56e2b
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 10:55
5538fc3
to
77b8e58
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 10:55
dd56e2b
to
eb1de29
Compare
danyx23
force-pushed
the
fetch-grapher-config-by-uuid
branch
from
September 10, 2024 11:14
77b8e58
to
d8b5bc0
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 11:15
eb1de29
to
380b1f5
Compare
danyx23
changed the base branch from
fetch-grapher-config-by-uuid
to
graphite-base/3880
September 10, 2024 11:31
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 11:31
380b1f5
to
02cf775
Compare
danyx23
force-pushed
the
render-thumbnails-by-uuid
branch
from
September 10, 2024 11:31
02cf775
to
2689b72
Compare
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR duplicates the thumbnail rendering logic into the top level so that we can render pngs at
/grapher/SLUG.png
and svgs at/grapher/SLUG.svg
. It also adds thumbnail rendering at/grapher/by-uuid/UUID.png
and.svg
.The HTML rewriting (of og images) is changed to point to the new
/grapher/SLUG.png
route.The old thumbnail rendering at
/grapher/thumbnail/SLUG
is kept for now so that existing fetches will still work until the various cached versions of the HTML have expired.