Skip to content

Commit

Permalink
Remove outdated comments
Browse files Browse the repository at this point in the history
We now rewrite the image meta tags dynamically in Cloudflare functions
to take query params into consideration.
  • Loading branch information
rakyi committed Jan 24, 2025
1 parent ec89e8c commit 4bef1e1
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 12 deletions.
9 changes: 0 additions & 9 deletions site/DataPageV2.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,6 @@ export const DataPageV2 = (props: {
}).plaintext
} else pageDesc = "An interactive visualization from Our World in Data."

// Due to thumbnails not taking into account URL parameters, they are often inaccurate on
// social media. We decided to remove them and use a single thumbnail for all charts.
// See https://github.com/owid/owid-grapher/issues/1086
//
// const imageUrl = urljoin(
// baseGrapherUrl,
// "exports",
// `${grapher.slug}.png?v=${grapher.version}`
// )
const imageUrl: string = urljoin(baseUrl, "default-grapher-thumbnail.png")
const imageWidth = "1200"
const imageHeight = "628"
Expand Down
3 changes: 0 additions & 3 deletions site/multiDim/MultiDimDataPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ export function MultiDimDataPage({
imageMetadata,
tagToSlugMap,
}
// Due to thumbnails not taking into account URL parameters, they are often inaccurate on
// social media. We decided to remove them and use a single thumbnail for all charts.
// See https://github.com/owid/owid-grapher/issues/1086
const imageUrl: string = urljoin(baseUrl, "default-grapher-thumbnail.png")
const imageWidth = "1200"
const imageHeight = "628"
Expand Down

0 comments on commit 4bef1e1

Please sign in to comment.