feat(vax,chn): Reduce running time and still ensure data validity #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aywi
commented
Apr 29, 2022
| try: | ||
| record = self._parse_data_complete(driver, link) | ||
| except: | ||
| print("Failed to parse:", link) |
There was a problem hiding this comment.
I don't know whether "print" is a right statement to use in this project when I want to output an acceptable error.
There was a problem hiding this comment.
If we want the pipeline to be aware that something is not working for a country, we simply raise Exceptions.
So here I would use
except:
raise Exception(f"Failed to parse {link}")There was a problem hiding this comment.
@lucasrodes Thanks! Since the only possible exception in the subroutine is TimeoutException (in two different locations), I will cancel the try-except and let them happen in the subroutine. See #2621.
|
LGTM - working! Thanks @aywi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the title.