Add magic comment to use mutable strings #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texpert
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
LGTM, @brian-kephart!
One relevant note - we have the Style/FrozenStringLiteralComment completely disabled in the .rubocop.yml file. WDYT of removing this clause and fixing all the occurrences?! There could be dragons, though :)
|
@texpert I would support that. It concerns me that I did not seen any deprecation warnings in the CI output for this repo, though. I caught the issue on another app that uses Camaleon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4 issues deprecation warnings when mutating strings in a file that does not have a
frozen_string_literal: falsecomment. When testing my app locally with Ruby 3.4, there are deprecation warnings because plugin_routes.rb uses mutated strings.This PR adds a magic comment to that file to silence the deprecation warnings and to ensure that the current behavior will continue even after a future version of Ruby freezes strings by default.