Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major rewrite + improvements in many areas #8

Open
wants to merge 191 commits into
base: master
Choose a base branch
from
Open

Major rewrite + improvements in many areas #8

wants to merge 191 commits into from

Conversation

mbs38
Copy link

@mbs38 mbs38 commented Oct 22, 2018 •
edited
Loading

Hi,
first off: Of course I do not expect this to be merged.

My little rewrite has brought some improvements:

  • more abstraction when writing to coils/registers using mqtt. Writing is now possible without having to know slave id, reference, function code etc.
  • specific coils/registers can be made read only
  • multiple slave devices on one bus are now fully supported
  • polling speed has been increased sgnificantly. With modbus RTU @ 38400 baud more than 80 transactions per second have been achieved.
  • switched over to pymodbus which is in active development

I've made so many changes that compatibility is broken BUT my changes might be very useful considering the issues of modbus2mqtt.

So if you're interested: https://github.com/mbs38/spicierModbus2mqtt

But beware: this is a beta or maybe even an alpha version Can be considered stable now.

mbs38 and others added 30 commits October 22, 2018 14:45
@mbs38
Commit all changes
4863116
@mbs38
updated readme, threw out old stuff that does not apply anymore
ce54a5e
@mbs38
Added some command line examples
cc01a24
@mbs38
-
541a05a
@mbs38
Added verbosity argument.
e239019
@mbs38
Added VERY basic error handling for modbus communication.
b1a79d9
@mbs38
Added more error handling and error messages
4907d89
@mbs38
Removed syslog logging. syslog is deprecated anyway..
f4e07b2
@mbs38
Added autoremove feature for failed pollers.
d09fff7
@mbs38
Ensure that the program actually terminates..
f2a63c9
@mbs38
Added python3-serial to install instructions
ed27521
@mbs38
Addded command line argument for setting break time in main loop.
94545ee
@mbs38
Revert "Addded command line argument for setting break time in main l…
45000be 
…oop."

This reverts commit 94545ee.
@mbs38
Added set loop time argument
43a4601
@mbs38
Revert "Revert "Addded command line argument for setting break time i…
0ffd123 
…n main loop.""

This reverts commit 45000be.
@mbs38
Revert "Revert "Revert "Addded command line argument for setting brea…
753064c 
…k time in main loop."""

This reverts commit 0ffd123.
@mbs38
Cleanup
4a68a43
@mbs38
some examples
3245d56
@mbs38
fix
a91aef2
@mbs38
some more
cb2fecc
@mbs38
Update README.md
627bd82
@mbs38
cleanup
e54dd66
@mbs38
Put some data in some other places to make implementing the home
f2d80bb 
assistant stuff a little easier..
@mbs38
Adding devices to home-assistant
bd07785
@mbs38
Fixed bad path
a3a8587
@mbs38
More elaborate Error handling.
95833a3
@mbs38
Nicer error handling.
d81e5a9
@mbs38
Fixed some bugs
a25e6cc
@mbs38
More elaborate comments
52deaf6
@mbs38
More examples
c237f96
phe95 and others added 30 commits October 4, 2022 14:06
@phe95
Fix negative float values (#17)
b018121
@tylerkoldenjtp
Update README.md (#15)
e393f71 
Replace failing MQTT host iot.eclipse.org with working host mqtt.eclipseprojects.io
@soluga
Implementation of signed int32-values (#16)
57278c2 
Implemented signed Int32-values
@mbs38
Changed version to 0.63
8a3bfc8
@ghstefan
Get dockerbuild running again (#18)
b0adafc 
* Ignore the root warning for the install

* fixed docker build issue

* ensure correct indent

* using plain pip again

* added changelog entrry

Co-authored-by: Stefan Fischer <[email protected]>
@mbs38
Insure compatibility with new version of pymodbus
ea994f1
@mbs38
Clean up readme
e725822
@mbs38
Print Modbus exception responses
a39c18a
@mbs38
Disable scaling on writing. Implementation not sufficient for all dat…
4033c58 
…a types, may cause crashes.
@mbs38
Disable broken parse functions for int32LE and int32BE
0717fa0
@mbs38
Don't use fc "write multiple registers" by default
687b9a9
@mbs38
Refactoring
1184be6
@mbs38
Add data type list-uint16 (space seperated list)
bf3acd6
@marcusbirkin
Docker: Resolve missing serial module (#21)
605cab2
@mbs38
Fix argument in modbus read/write calls name (pobably due to some ver…
74406a7 
…y old changes in pymodbus?)
@mbs38
Version 0.67
1fa496c
@mbs38
replace unit= with slave=
e55ec6c
@mbs38
move datatypes to new file
8601eb7
@mbs38
Use async implementation of pymodbus, remove loop-break, cleanup
7b43e71
@mbs38
Add avoid-fc6 option, cleanup, logging
6e0e6b5
@mbs38
Increment version
2e427c0
@mbs38
Merge branch 'use-async'
a1ee82f
@mbs38
Update README, fix typos
6281a7d
@mbs38
Fix broken pip package
3f7019e
@mbs38
Increment version
84510a6
@mbs38
Add break inbetween requests on modbus (assume 2ms fixed break time),…
1c8e188 
… increment version
@mbs38
Add datatype list-uint16 again, increment version
15972bb
@mbs38
Add loop break option again, reconnect on tcp modbus connection loss
952ed56
@mbs38
Increment version
ed40061
@mbs38
Update README
92784f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.