-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major rewrite + improvements in many areas #8
Open
mbs38
wants to merge
191
commits into
owagner:master
Choose a base branch
from
mbs38:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace failing MQTT host iot.eclipse.org with working host mqtt.eclipseprojects.io
Implemented signed Int32-values
* Ignore the root warning for the install * fixed docker build issue * ensure correct indent * using plain pip again * added changelog entrry Co-authored-by: Stefan Fischer <[email protected]>
…a types, may cause crashes.
…y old changes in pymodbus?)
… increment version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
first off: Of course I do not expect this to be merged.
My little rewrite has brought some improvements:
I've made so many changes that compatibility is broken BUT my changes might be very useful considering the issues of modbus2mqtt.
So if you're interested: https://github.com/mbs38/spicierModbus2mqtt
But beware: this is a beta or maybe even an alpha versionCan be considered stable now.