This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Add setlist search #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, disabled url hook
Last.fm is now a service started when the bot starts, and available to all commands/hooks via self.bot.lastfm. This is a refactor to support future commands/hooks.
Move Last.fm-related things to new service category
Also added tester command "!gmusic"
… users to the --all option
Added simple setlist command scaffolding Added simple call to setlist.fm to find a setlist Added support for services to use each other
Added basics of setlist.fm service
Added ability to lookup a song by searchterms and get the best result from gmusic. Added this to the !now command to fill in missing album info (last.fm often misses the album).
I made the assumption that if last.fm didn't know, the album, you could definitely get the results from GPM, since you're listening to the music there. However, since the hangouts bot masquerades as a separate user, it won't know about uploaded music of a user. This can lead to GPM searches with no album results.
Fix no gpm album
Also, random small refactors/linting fixes
Conflicts: services/lastfm.py
using "!convert <spotify embed url>", the bot will attempt to scrape the playlist, find the songs, create a GPM playlist with the same songs, and return the share url for that playlist.
Add spotify embed converter
Shorten spotify links
'!playlist recent' shows 5 most recent playlist
'!playlist search' finds playlists that contain searchterm in them
'!playlist convert' takes the place of '!convert', to convert a spotify
playlist to a gmusic playlist, hosted by the bot.
TODO: should limit results from search. Should also fail if searching
for ''
Playlist commands
Make playlist formatting better
!setlist now returns the average setlist for a given artist
Bugfix self vs bot
'!setlist show <band>' shows a preview of what a setlist would be for a given band. '!setlist generate <band>' generates a playlist with those songs, and shares the playlist in the channel.
!setlist now has show/generate commands
|
@rattboi I just saw this - didn't get an email for some reason - and it looks pretty good to me. I'll review it by tomorrow and then merge |
|
I've actually not really been adding features to the bot proper, just
music-related commands/hooks. I'm not sure I have anything you'd wanna
merge into mainline.
…On Thu, Jul 6, 2017 at 12:42 PM, ovkulkarni ***@***.***> wrote:
@rattboi <https://github.com/rattboi> I just saw this - didn't get an
email for some reason - and it looks pretty good to me. I'll review it by
tomorrow and then merge
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKImgxeWOprg5Yy47FbyxyM8er6gUPmks5sLTjAgaJpZM4N5J1U>
.
|
|
@rattboi even though it isn't part of the bot itself, people may like to use the commands you've written, so I'll probably end up merging your PR |
|
@rattboi it may also be a good idea to take a look at the failed build for code readability purposes |
|
Sure, that's a good idea. I'll look into it. I don't know all the python
idioms.
…On Jul 6, 2017 19:19, "ovkulkarni" ***@***.***> wrote:
@rattboi <https://github.com/rattboi> it may also be a good idea to take
a look at the failed build for code readability purposes
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKImjdC8xWEaZtrd2_pBAU7YQSl1yk8ks5sLZWsgaJpZM4N5J1U>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.