feat: allow skipping recording rule checks entirely #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes LGTM thank you @zeroshift for your contributions. |
wilfriedroset
approved these changes
Oct 8, 2024
|
would you be able to sign your commits so that I can merge please? |
zeroshift
force-pushed
the
np_skip_rule_check
branch
from
ded45c9
to
9bda644
Compare
|
Thanks @wilfriedroset! Signed the commits now. |
raspbeguy
approved these changes
Oct 9, 2024
vaxvms
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding this PR to allow overriding the requirement of at least a single
:in a recording rule. Some rules are not aggregations or come from 3rd parties, for instance projects like https://sloth.dev/.This PR also includes minor bugfixes as well as updating the terraform/mimir test matrices, which I'm happy to submit separate PRs for.