fix: CLI now returns 1 when signature verification fails in JSON mode

Signed-off-by: Pierre-Henri Symoneaux <[email protected]>
ovh · Nov 18, 2024 · 20f9c76 · 20f9c76
1 parent 8ae2bbc
commit 20f9c76
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/cmd/okms/keys/sign.go b/cmd/okms/keys/sign.go
@@ -84,12 +84,11 @@ SIGNATURE can also be passed from a file or stdin using '-' or '@'. Stdin can ho
 			valid := exit.OnErr2(common.Client().Verify(cmd.Context(), keyId, params.signatureAlgorithm.Alg(), true, data, signature))
 			if cmd.Flag("output").Value.String() == string(flagsmgmt.JSON_OUTPUT_FORMAT) {
 				output.JsonPrint(valid)
-			} else {
-				if valid {
-					fmt.Println("Signature is valid")
-				} else {
-					exit.OnErr(errors.New("Signature invalid"))
-				}
+			} else if valid {
+				fmt.Println("Signature is valid")
+			}
+			if !valid {
+				exit.OnErr(errors.New("Signature invalid"))
 			}
 		} else {
 			resp := exit.OnErr2(common.Client().GetServiceKey(cmd.Context(), keyId, utils.PtrTo(types.Jwk)))