feat(dedicated): add iplb delete option for us #14243
Open
+371
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: MANAGER-15666 Signed-off-by: soufien mhelhali <[email protected]>
mhelhali-soufien
requested review from
antonymarion,
MaximeBajeux and
ghyenne
github-actions
bot
added
universe-bare-metal-cloud
translation required
feature
|
| "iplb_terminate_service_success": "Votre demande de suppression de votre service a été prise en compte. Un e-mail contenant la procédure vous a été envoyé.", | ||
| "iplb_terminate_service_error": "Une erreur est survenue lors de la demande de suppression de votre service. {{error}}", | ||
| "iplb_terminate_service_confirm_input": "Entrez \"TERMINATE\" dans le champ ci-dessous pour confirmer", | ||
| "iplb_terminate_service_terminate_valide": "Valider", |
There was a problem hiding this comment.
Suggested change
| "iplb_terminate_service_terminate_valide": "Valider", | |
| "iplb_terminate_service_terminate_valid": "Valider", |
| }, | ||
| redirectTo: (transition) => |
There was a problem hiding this comment.
Why are we removing this redirection for empty case ?
Comment on lines
+26
to
+43
| terminate() { | ||
| this.$http | ||
| .post(`/ipLoadbalancing/${this.service.serviceName}/terminate`) | ||
| .then(() => { | ||
| this.Alerter.success( | ||
| this.$translate.instant('iplb_terminate_service_success'), | ||
| ); | ||
| }) | ||
| .catch((err) => { | ||
| this.Alerter.error( | ||
| this.$translate.instant('iplb_terminate_service_error', { | ||
| t0: err.data ? err.data.message : err.message, | ||
| }), | ||
| this.alertId, | ||
| ); | ||
| }); | ||
| this.$uibModalInstance.close(); | ||
| } |
There was a problem hiding this comment.
Suggested change
| terminate() { | |
| this.$http | |
| .post(`/ipLoadbalancing/${this.service.serviceName}/terminate`) | |
| .then(() => { | |
| this.Alerter.success( | |
| this.$translate.instant('iplb_terminate_service_success'), | |
| ); | |
| }) | |
| .catch((err) => { | |
| this.Alerter.error( | |
| this.$translate.instant('iplb_terminate_service_error', { | |
| t0: err.data ? err.data.message : err.message, | |
| }), | |
| this.alertId, | |
| ); | |
| }); | |
| this.$uibModalInstance.close(); | |
| } | |
| terminate() { | |
| this.isDeleting = true; | |
| this.$http | |
| .post(`/ipLoadbalancing/${this.service.serviceName}/terminate`) | |
| .then(() => { | |
| this.Alerter.success( | |
| this.$translate.instant('iplb_terminate_service_success'), | |
| ); | |
| this.$uibModalInstance.close(); | |
| }) | |
| .catch((err) => { | |
| this.Alerter.error( | |
| this.$translate.instant('iplb_terminate_service_error', { | |
| t0: err.data ? err.data.message : err.message, | |
| }), | |
| this.alertId, | |
| ); | |
| this.$uibModalInstance.dismiss(); | |
| }) | |
| .finally(() => { | |
| this.isDeleting = false; | |
| }); | |
| } |
sachinrameshn
requested changes
Nov 26, 2024
| this.$http = $http; | ||
| this.Alerter = Alerter; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| $onInit() { | |
| this.isDeleting = false; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master/release/**/developDescription
Related