Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: work around outline generation bug #1108

Open
wants to merge 1 commit into
base: release
Choose a base branch
from
Open

fix: work around outline generation bug #1108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions tutor/commands/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@ def importdemocourse(
# Import into CMS
python ./manage.py cms import ../data "$course_root"

# Work around bug where outline is not generated
python ./manage.py cms update_course_outline course-v1:OpenedX+DemoX+DemoCourse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it impacting all the courses or only under certain circumstances? If the outline is not generated in initial import, does it not generate when a user navigates to LMS or edits something on CMS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbrandes Hi, catching up on ☝🏽

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbrandes Hi, pinging for ☝🏽 . Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. I would guess this impacts all courses that are imported using the same command, yes, but I haven't actually tested it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arbrandes Were you able to test ☝🏽 ? Thanks

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I figured out is that this only happens in dev mode, but with any course.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it happens for every course, how does this fix the larger problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another issue with the proposed fix, which is that it does not work when importing courses other than course-v1:OpenedX+DemoX+DemoCourse.

AFAIU this is not a bug in Tutor, but in edx-platform, and it should be fixed there. We can cherry-pick the change here if necessary.


# Re-index courses
./manage.py cms reindex_course --all --setup"""
yield ("cms", template)
Expand Down
Loading